fix: Amount input correctly handles numbers and dots #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvarley100
reviewed
Mar 17, 2021
packages/shared/lib/units.ts
Outdated
| return "0"; | ||
| } | ||
| if (!UNIT_MAP[fromUnit]) { | ||
| throw new Error(`Unrecognized fromUnit ${fromUnit}`); |
There was a problem hiding this comment.
Do we not need to catch these?
There was a problem hiding this comment.
I mean they are never going to fire, but still, seems odd to leave them uncaught.
There was a problem hiding this comment.
I just pulled this method from my iota.js lib which already did the necessary conversion.
cvarley100
approved these changes
Mar 17, 2021
rajivshah3
reviewed
Mar 17, 2021
cvarley100
force-pushed
the
fix/amount-input
branch
from
1509ff1
to
6046374
Compare
rajivshah3
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The amount input now handles input correctly.
Input control now has integer and float support, not just numeric.
Scientific notation is handled correctly.
Additional focus visuals added.
Autofocus on send page.
Defaults to empty.
Links to any relevant issues
Fixes #473
Type of change
Choose a type of change, and delete any options that are not relevant.
How the change has been tested
Tested on windows.
Change checklist
Add an
xto the boxes that are relevant to your changes, and delete any items that are not.