Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: market value feature and balance enhancements #4819

Merged
merged 20 commits into from Nov 15, 2022
Merged

feat: market value feature and balance enhancements #4819

merged 20 commits into from Nov 15, 2022

Conversation

nicole-obrien
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Relevant Issues

Please list any related issues using development keywords.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@nicole-obrien nicole-obrien added type:feature Adding a new feature or functionality context:wallet stardust Related to the Stardust Protocol labels Oct 6, 2022
@nicole-obrien nicole-obrien self-assigned this Oct 6, 2022
This was linked to issues Oct 6, 2022
[Task]: Add fiat price data for shimmer #4817
Closed
[Task]: Refactor and finalise the total and available balance that is show across the app #3873
Closed
nicole-obrien and others added 2 commits November 2, 2022 09:55
@nicole-obrien @maxwellmattryan
feat: initial market data module
adc97dc 
Co-authored-by: Matthew Maxwell <maxwellmattryan@users.noreply.github.com>
@nicole-obrien
feat: add market price to asset and adjust currency dropdown
97796b0
@kraftjs kraftjs linked an issue Nov 14, 2022 that may be closed by this pull request
[Task]: Add fiat conversion or placeholder to the send form #3282
Closed
@nicole-obrien nicole-obrien marked this pull request as ready for review November 14, 2022 18:47
MarkNerdi996
MarkNerdi996 suggested changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments, else it looks good and works as expected!

packages/desktop/views/dashboard/settings/views/general/Currency.svelte Outdated Show resolved Hide resolved
packages/shared/lib/core/market/stores/market-coin-prices.store.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/market/utils/getMarketAmountFromAssetValue.ts Outdated Show resolved Hide resolved
MarkNerdi996
MarkNerdi996 approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkNerdi996 MarkNerdi996 merged commit 5d8d53d into stardust-develop Nov 15, 2022
@MarkNerdi996 MarkNerdi996 deleted the feat/market-data-for-shimmer branch November 15, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkNerdi996 MarkNerdi996 MarkNerdi996 approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@nicole-obrien nicole-obrien

Labels
context:wallet stardust Related to the Stardust Protocol type:feature Adding a new feature or functionality
Projects
None yet
Milestone
No milestone
2 participants
@nicole-obrien @MarkNerdi996