Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: utils module #4820

Merged
merged 12 commits into from Oct 20, 2022
Merged

refactor: utils module #4820

merged 12 commits into from Oct 20, 2022

Conversation

maxwellmattryan
Copy link
Contributor

@maxwellmattryan maxwellmattryan commented Oct 6, 2022 •
edited

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Relevant Issues

Please list any related issues using development keywords.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@maxwellmattryan maxwellmattryan added type:refactor Refactor code stardust Related to the Stardust Protocol labels Oct 6, 2022
@maxwellmattryan maxwellmattryan self-assigned this Oct 6, 2022
@maxwellmattryan maxwellmattryan linked an issue Oct 6, 2022 that may be closed by this pull request
[Task]: Refactor utils module #3964
Closed
12 tasks
@maxwellmattryan maxwellmattryan marked this pull request as ready for review October 6, 2022 22:30
Tuditi
Tuditi suggested changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I left some minor comments. You also have to check the conflicts again 😅

packages/shared/lib/core/utils/convert.utils.ts Outdated Show resolved Hide resolved
Tuditi
Tuditi approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, LGTFM! 🥳

@Tuditi Tuditi merged commit abce41c into stardust-develop Oct 20, 2022
@Tuditi Tuditi deleted the refactor/utils-module branch October 20, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tuditi Tuditi Tuditi approved these changes

@nicole-obrien nicole-obrien Awaiting requested review from nicole-obrien

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@maxwellmattryan maxwellmattryan

Labels
stardust Related to the Stardust Protocol type:refactor Refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Refactor utils module
2 participants
@maxwellmattryan @Tuditi