Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove kdbx #4890

Merged
merged 4 commits into from Oct 14, 2022
Merged

chore: remove kdbx #4890

merged 4 commits into from Oct 14, 2022

Conversation

jeeanribeiro
Copy link
Contributor

Summary

Removes KDBX and all its related content (seedvault, locales, etc.) because they are not used

Changelog

- Removes KDBX lib and its related code
- Removes seed vault code
- Removes seed vault locales

Relevant Issues

closes #4887

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro added type:chore House-keeping etc. stardust Related to the Stardust Protocol labels Oct 14, 2022
@jeeanribeiro jeeanribeiro self-assigned this Oct 14, 2022
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@Tuditi Tuditi merged commit 531d997 into stardust-develop Oct 14, 2022
@Tuditi Tuditi deleted the chore/remove-kdbx branch October 14, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:chore House-keeping etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants