Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI/split send button #4891

Merged
merged 5 commits into from Oct 14, 2022
Merged

UI/split send button #4891

merged 5 commits into from Oct 14, 2022

Conversation

MarkNerdi996
Copy link
Contributor

Summary

This PR updates the Send button such that it includes multiple different functions.

Changelog

- implement split send button

Relevant Issues

Closes #4848

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 added context:wallet type:ui stardust Related to the Stardust Protocol labels Oct 14, 2022
@MarkNerdi996 MarkNerdi996 self-assigned this Oct 14, 2022
@MarkNerdi996 MarkNerdi996 changed the base branch from develop to stardust-develop October 14, 2022 09:35
Tuditi
Tuditi reviewed Oct 14, 2022
View reviewed changes
packages/shared/features/features.ts Outdated
Comment on lines 101 to 108
sendAndReceive: {
enabled: true,
},
send: {
nft: {
enabled: false,
},
},
Copy link
Contributor

@Tuditi Tuditi Oct 14, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this can go under sendAndReceive?

Suggested change
sendAndReceive: {
enabled: true,
},
send: {
nft: {
enabled: false,
},
},
sendAndReceive: {
enabled: true,
nft: {
enabled: false,
},
},

Tuditi
Tuditi reviewed Oct 14, 2022
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, but looks and works good!

Tuditi
Tuditi approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@Tuditi Tuditi merged commit a80591b into stardust-develop Oct 14, 2022
@Tuditi Tuditi deleted the ui/split-send-button branch October 14, 2022 14:09
This was referenced Oct 17, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tuditi Tuditi Tuditi approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@MarkNerdi996 MarkNerdi996

Labels
context:wallet stardust Related to the Stardust Protocol type:ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Create Split Button for different sending flows
2 participants
@MarkNerdi996 @Tuditi