Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: popup module #4925

Merged
merged 5 commits into from Oct 19, 2022
Merged

Conversation

maxwellmattryan
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

This PR refactors existing code from the old lib/popup.ts file into a auxiliary popup module.

Changelog

- Refactor existing code into auxiliary popup module
- Update library modules for docs

Relevant Issues

Please list any related issues using development keywords.

Closes #3974

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

Check general app functionality, particularly where popups are involved.

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@maxwellmattryan maxwellmattryan added type:refactor Refactor code stardust Related to the Stardust Protocol labels Oct 18, 2022
@maxwellmattryan maxwellmattryan self-assigned this Oct 18, 2022
@maxwellmattryan maxwellmattryan linked an issue Oct 18, 2022 that may be closed by this pull request
10 tasks
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxwellmattryan maxwellmattryan merged commit 5419f55 into stardust-develop Oct 19, 2022
@maxwellmattryan maxwellmattryan deleted the refactor/popup-module branch October 19, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Refactor popup module
2 participants