Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor selector input #4931

Merged
merged 2 commits into from Oct 19, 2022
Merged

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Oct 19, 2022

Summary

Started creating a generic selector component.

...

Changelog

- Added SelectorInput.svelte

Relevant Issues

#4930

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi added the type:chore House-keeping etc. label Oct 19, 2022
@Tuditi Tuditi self-assigned this Oct 19, 2022
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tuditi Tuditi merged commit 3d805a6 into stardust-develop Oct 19, 2022
@Tuditi Tuditi deleted the chore/refactor-selector-input branch October 19, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:chore House-keeping etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants