Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary code in onboarding routes #4932

Merged
merged 4 commits into from Oct 19, 2022

Conversation

paul-boegelsack
Copy link
Contributor

@paul-boegelsack paul-boegelsack commented Oct 19, 2022

Summary

This PR removes switch cases of previously deleted routes

Changelog

- Cleans mobile app setup router
- Cleans mobile profile backup router
- Removes ledger import route and related code

Relevant Issues

Please list any related issues using development keywords.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@paul-boegelsack paul-boegelsack added type:fix Fix for bug platform:mobile stardust Related to the Stardust Protocol labels Oct 19, 2022
@paul-boegelsack paul-boegelsack self-assigned this Oct 19, 2022
@paul-boegelsack paul-boegelsack changed the title fix: remove prevoiusly deleted routes fix: remove checks for previously deleted routes Oct 19, 2022
@paul-boegelsack paul-boegelsack changed the title fix: remove checks for previously deleted routes fix: remove unnecessary code in onboarding routes Oct 19, 2022
@begonaalvarezd begonaalvarezd merged commit 0e6b789 into stardust-develop Oct 19, 2022
@begonaalvarezd begonaalvarezd deleted the fix/clean-routers branch October 19, 2022 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants