Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: network selector on send #4982

Merged
merged 13 commits into from Oct 20, 2022
Merged

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Oct 19, 2022

Summary

Added a network selector to the send form popup

...

Changelog

- Added a network selector

Relevant Issues

closes: #4926

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi linked an issue Oct 19, 2022 that may be closed by this pull request
3 tasks
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some specific comments / questions, but generally:

  • Not sure if related to this PR but the error isn't displayed in the UI (beneath the address input) whenever no address is entered and you try to click "Send"
  • Definitely not related to this PR, but the Figma designs say "Recipient" whereas currently it's saying "Alias" for the address inputs below the network selector.

Code and UI looks good though!

@jeeanribeiro jeeanribeiro added type:feature Adding a new feature or functionality stardust Related to the Stardust Protocol labels Oct 19, 2022
@Tuditi Tuditi force-pushed the feat/network-selector-on-send branch from 023e73f to f96869d Compare October 20, 2022 09:14
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and looks really good,
left a few small comments

@Tuditi Tuditi force-pushed the feat/network-selector-on-send branch from ba06042 to 7576c64 Compare October 20, 2022 10:19
@Tuditi Tuditi dismissed maxwellmattryan’s stale review October 20, 2022 12:24

Preparing our pair programming sesh ;)

@Tuditi Tuditi merged commit 66230d4 into stardust-develop Oct 20, 2022
@Tuditi Tuditi deleted the feat/network-selector-on-send branch October 20, 2022 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:feature Adding a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Create Network Selector Dropdown
4 participants