New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: network selector on send #4982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some specific comments / questions, but generally:
- Not sure if related to this PR but the error isn't displayed in the UI (beneath the address input) whenever no address is entered and you try to click "Send"
- Definitely not related to this PR, but the Figma designs say "Recipient" whereas currently it's saying "Alias" for the address inputs below the network selector.
Code and UI looks good though!
packages/shared/lib/core/network/constants/destination-network-address.constant.ts
Outdated
Show resolved
Hide resolved
023e73f
to
f96869d
Compare
…ork-selector-on-send
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works and looks really good,
left a few small comments
ba06042
to
7576c64
Compare
7576c64
to
46e9817
Compare
Preparing our pair programming sesh ;)
Summary
Added a network selector to the send form popup
...
Changelog
Relevant Issues
closes: #4926
...
Testing
Platforms
Instructions
...
Checklist