Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: dashboard header setup #4990

Merged
merged 8 commits into from Oct 20, 2022
Merged

Conversation

paul-boegelsack
Copy link
Contributor

@paul-boegelsack paul-boegelsack commented Oct 19, 2022

Summary

This PR initializes the dashboard header

Changelog

- Adds a header section inside the dashboard
- Adds a top bar with buttons for the profile menu, account actions and account switcher to the dashboard header
- Adds a balance display to the dashboard header
- Adds send and receive buttons to the dahsboard header

Relevant Issues

Closes #4934
Closes #4935
Closes #4936
Closes #4937
Closes #4938

Testing

In order to test, you have to:

  • in packages/desktop/index.js replace import App from './App.svelte' with import App from '../mobile/App.svelte'
  • in packages/shared/lib/core/profile/actions/active-profile/login.ts replace import { loginRouter } from '@core/router' with import { loginRouter } from '../../../../../../mobile/lib/core/router'.

Activate features in './packages/mobile/features/features.ts':

  • balance
  • profileActions
  • accountSwitcher
  • accountActions

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@paul-boegelsack paul-boegelsack added platform:mobile type:ui stardust Related to the Stardust Protocol labels Oct 19, 2022
@paul-boegelsack paul-boegelsack self-assigned this Oct 19, 2022
@paul-boegelsack paul-boegelsack marked this pull request as ready for review October 20, 2022 11:41
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking amazing 🚀 great work 💪🏼
Just added couple mini comments

packages/mobile/components/TopBar.svelte Outdated Show resolved Hide resolved
packages/mobile/features/features.ts Outdated Show resolved Hide resolved
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀 🚀

@begonaalvarezd begonaalvarezd merged commit 6ac2418 into stardust-develop Oct 20, 2022
@begonaalvarezd begonaalvarezd deleted the ui/dashboard-header-setup branch October 20, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment