New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui: dashboard header setup #4990
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-boegelsack
added
platform:mobile
type:ui
stardust
Related to the Stardust Protocol
labels
Oct 19, 2022
paul-boegelsack
force-pushed
the
ui/dashboard-header-setup
branch
from
October 20, 2022 11:18
dd3184f
to
79f5360
Compare
This was
linked to
issues
Oct 20, 2022
begonaalvarezd
requested changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking amazing 🚀 great work 💪🏼
Just added couple mini comments
paul-boegelsack
force-pushed
the
ui/dashboard-header-setup
branch
from
October 20, 2022 13:01
c3b9f81
to
4b200b2
Compare
packages/shared/components/atoms/buttons/AccountActionsButton.svelte
Outdated
Show resolved
Hide resolved
begonaalvarezd
approved these changes
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR initializes the dashboard header
Changelog
Relevant Issues
Closes #4934
Closes #4935
Closes #4936
Closes #4937
Closes #4938
Testing
In order to test, you have to:
packages/desktop/index.js
replaceimport App from './App.svelte'
withimport App from '../mobile/App.svelte'
packages/shared/lib/core/profile/actions/active-profile/login.ts
replaceimport { loginRouter } from '@core/router'
withimport { loginRouter } from '../../../../../../mobile/lib/core/router'
.Activate features in './packages/mobile/features/features.ts':
Platforms
Instructions
...
Checklist