Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mobile receive drawer #4998

Merged
merged 7 commits into from Oct 21, 2022
Merged

Conversation

begonaalvarezd
Copy link
Member

Summary

Please summarize your changes, describing what they are and why they were made.

This PR includes the following:

  • drawer component
  • dashboard drawers based on routing
  • receive drawer (without share button because we dont have a share feature)
  • split send and receive feature flags and enable receive because the drawer is implemented in this PR

Changelog

feat: add mobile receive drawer

Relevant Issues

Please list any related issues using development keywords.

Close #4942

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

In order to test, you have to:

  • in packages/desktop/index.js replace import App from './App.svelte' with import App from '../mobile/App.svelte'
  • in packages/shared/lib/core/profile/actions/active-profile/login.ts replace import { loginRouter } from '@core/router' with import { loginRouter } from '../../../../../../mobile/lib/core/router'. We have to refactor a bit the shared core modules to welcome mobile, in the meantime, we teak

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@begonaalvarezd begonaalvarezd added type:feature Adding a new feature or functionality platform:mobile stardust Related to the Stardust Protocol labels Oct 20, 2022
@begonaalvarezd begonaalvarezd self-assigned this Oct 20, 2022
@begonaalvarezd begonaalvarezd linked an issue Oct 20, 2022 that may be closed by this pull request
5 tasks
Copy link
Contributor

@paul-boegelsack paul-boegelsack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and behaves really nice 🔥 👍

@paul-boegelsack paul-boegelsack merged commit b20fef0 into stardust-develop Oct 21, 2022
@paul-boegelsack paul-boegelsack deleted the feat/mobile-receive branch October 21, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:feature Adding a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add receive feature
2 participants