Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: add storage deposit to native token minting #5000

Conversation

MarkNerdi996
Copy link
Contributor

Summary

This PR includes the preparation of the foundry creation to deduce and display the required storage deposit

Changelog

- add storage deposit to native token minting

Relevant Issues

Closes #4892

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 added type:enhancement Enhancement to existing feature context:wallet stardust Related to the Stardust Protocol labels Oct 21, 2022
@MarkNerdi996 MarkNerdi996 self-assigned this Oct 21, 2022
@MarkNerdi996 MarkNerdi996 linked an issue Oct 21, 2022 that may be closed by this pull request
Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Storage deposit key is showing as the localisation key on the confirmation page.

@nicole-obrien
Copy link
Contributor

Also something seems to have broken the alias id selector and it is showing undefined on the mint nft form. Perhaps we can fix that quickly in this pr.

Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Tested it out and some minor comments:

MarkNerdi996 and others added 3 commits October 24, 2022 12:06
…opup.svelte

Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>
…ent/add-storage-deposit-to-native-token-minting
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@Tuditi Tuditi dismissed nicole-obrien’s stale review October 24, 2022 14:46

Checked the changes

@Tuditi Tuditi merged commit a613cbb into stardust-develop Oct 24, 2022
@Tuditi Tuditi deleted the enhancement/add-storage-deposit-to-native-token-minting branch October 24, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:wallet stardust Related to the Stardust Protocol type:enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add storage deposit to Mint Native Token Confirmation
3 participants