New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: add storage deposit to native token minting #5000
enhancement: add storage deposit to native token minting #5000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Storage deposit key is showing as the localisation key on the confirmation page.
Also something seems to have broken the alias id selector and it is showing undefined on the mint nft form. Perhaps we can fix that quickly in this pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Tested it out and some minor comments:
-
In another PR, I refactored the AliasSelector out, but I didn't add a default value to
firefly/packages/shared/components/inputs/AliasInput.svelte
Lines 4 to 5 in 83b2ac5
export let alias: string export let error: string = ''
This PR seems the perfect place to initialize it back again 😈
packages/shared/components/popups/MintNativeTokenConfirmationPopup.svelte
Outdated
Show resolved
Hide resolved
packages/shared/components/popups/MintNativeTokenConfirmationPopup.svelte
Show resolved
Hide resolved
packages/shared/components/popups/MintNativeTokenConfirmationPopup.svelte
Outdated
Show resolved
Hide resolved
packages/shared/components/popups/MintNativeTokenConfirmationPopup.svelte
Outdated
Show resolved
Hide resolved
…opup.svelte Co-authored-by: Tuditi <45079109+Tuditi@users.noreply.github.com>
…ent/add-storage-deposit-to-native-token-minting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🔥
Summary
This PR includes the preparation of the foundry creation to deduce and display the required storage deposit
Changelog
Relevant Issues
Closes #4892
Testing
Platforms
Instructions
...
Checklist