New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sending l2 tx #5002
feat: add sending l2 tx #5002
Conversation
a97fd3a
to
e89dded
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed on the call heres the main improvements to make:
- Lets make it so that we are not converting anything until we actually call the send function, so we can store all the params in the new transaction store and go backwards and forwards with ease.
- Add a network subject type to store network and address or just address as the subject and then store this in the recipient of the new transaction
- Add a layer 2 params to the new transaction and potentially a flag to say its layer 2. Then in another task we can easily use this data to go backwards and forwards in the send flow or to show the layer 2 details rather than the metadata as hex.
- Add a feature flag to make the network field readonly in the mainnet profiles but not in dev profiles.
- Add a Shimmer Testnet EVM network so its different to the Shimmer EVM
a0169a8
to
7e20c7f
Compare
9b5a59c
to
32b83c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per our review call:
- some of file names for constants don't match the constant names
- we should move the smart contract params to the params of the function to make it fully generic
- we should rename getLayer2Metadata to make it clear this is for a specific contract and call
- Ideally we should be adding the gas budget onto the amount when creating the output as this is an addition to the user defined amount which is used in the allowance field of the contract
a2ac943
to
8aa82eb
Compare
12af190
to
59bff8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
This PR adds support for L1 -> L2 transactions.
Changelog
Relevant Issues
closes: #4981
Testing
Alias Output address representing SMR network: rms1pzw5y4e4y6gzkytvjp0ukgjgs37vd33uvnju9tuf6rrztnnw4tj7crw72ar
Follow the guide here to set-up your metamask for the Shimmer EVM: https://hackmd.io/SWpeUi_eTDKbnvK623vMmw#Configuring-MetaMask
In Firefly select the Shimmer EVM from the network drop-down and then input your EVM address in the recipient field (needs polish).
Platforms
Instructions
...
Checklist