Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: router modules #5020

Merged
merged 8 commits into from Oct 25, 2022
Merged

Conversation

maxwellmattryan
Copy link
Contributor

@maxwellmattryan maxwellmattryan commented Oct 25, 2022

Summary

Please summarize your changes, describing what they are and why they were made.

This PR makes a few changes to allow more compatible routing logic and code between platforms.

Changelog

- Please write a list of changes

Relevant Issues

Please list any related issues using development keywords.

...

Testing

In order to test mobile, you have to do the following steps:

  • in packages/desktop/index.js replace import App from './App.svelte' with import App from '../mobile/App.svelte'
  • in packages/shared/lib/core/profile/actions/active-profile/login.ts replace import { loginRouter } from '@core/router' with import { loginRouter } from '../../../../../../mobile/lib/core/router'.

Dont forget resizing your electron device view to a mobile one, eg Pixel 5
image

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@maxwellmattryan maxwellmattryan added type:refactor Refactor code stardust Related to the Stardust Protocol labels Oct 25, 2022
@maxwellmattryan maxwellmattryan changed the base branch from develop to stardust-develop October 25, 2022 17:05
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:trollface:

@maxwellmattryan maxwellmattryan marked this pull request as ready for review October 25, 2022 19:01
@maxwellmattryan maxwellmattryan merged commit ce0187c into stardust-develop Oct 25, 2022
@maxwellmattryan maxwellmattryan deleted the refactor/router-modules branch October 25, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants