Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: nft developer tool #5021

Merged
merged 14 commits into from Nov 7, 2022
Merged

enhancement: nft developer tool #5021

merged 14 commits into from Nov 7, 2022

Conversation

jeeanribeiro
Copy link
Contributor

@jeeanribeiro jeeanribeiro commented Oct 25, 2022 •
edited

Summary

Enhances NFT developer tool by adding field validation, refactoring, and JSON support.

Relevant Issues

closes #4914

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

  • Go through the flow of minting NFTs

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro added type:enhancement Enhancement to existing feature stardust Related to the Stardust Protocol labels Oct 25, 2022
@jeeanribeiro jeeanribeiro self-assigned this Oct 25, 2022
@jeeanribeiro jeeanribeiro force-pushed the enhancement/nft-developer-tool branch 6 times, most recently from 1a3644b to 7927d76 Compare October 27, 2022 00:41
@jeeanribeiro jeeanribeiro force-pushed the enhancement/nft-developer-tool branch 2 times, most recently from 84a0c87 to 9b55a67 Compare November 1, 2022 22:01
@jeeanribeiro jeeanribeiro linked an issue Nov 1, 2022 that may be closed by this pull request
[Task]: E12.M1 - Improve NFT developer tool #4914
Closed
6 tasks
@jeeanribeiro jeeanribeiro marked this pull request as ready for review November 1, 2022 22:04
kraftjs
kraftjs approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@kraftjs kraftjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👌. Just tested creating an NFT with attributes too. Here's the transaction: https://explorer.shimmer.network/testnet/transaction/0xdb3cf1697040179ccb7a1228ec7f07f6e835c74c206980fbf23825aa92777ad5

@kraftjs kraftjs merged commit 40cc022 into stardust-develop Nov 7, 2022
@kraftjs kraftjs deleted the enhancement/nft-developer-tool branch November 7, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftjs kraftjs kraftjs approved these changes

@cvarley100 cvarley100 Awaiting requested review from cvarley100

@MarkNerdi996 MarkNerdi996 Awaiting requested review from MarkNerdi996

Assignees

@jeeanribeiro jeeanribeiro

Labels
stardust Related to the Stardust Protocol type:enhancement Enhancement to existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: E12.M1 - Improve NFT developer tool
2 participants
@jeeanribeiro @kraftjs