Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: more utils submodules #5032

Merged
merged 11 commits into from Oct 26, 2022

Conversation

maxwellmattryan
Copy link
Contributor

@maxwellmattryan maxwellmattryan commented Oct 26, 2022

Summary

Please summarize your changes, describing what they are and why they were made.

A lot of the existing lib code that needed to be refactored was utils submodules.

Relevant Issues

Please list any related issues using development keywords.

Closes #5031

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

Test general app functionality.

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@maxwellmattryan maxwellmattryan added type:refactor Refactor code stardust Related to the Stardust Protocol labels Oct 26, 2022
@maxwellmattryan maxwellmattryan self-assigned this Oct 26, 2022
@maxwellmattryan maxwellmattryan linked an issue Oct 26, 2022 that may be closed by this pull request
18 tasks
@maxwellmattryan maxwellmattryan marked this pull request as ready for review October 26, 2022 18:45
Copy link
Contributor

@jeeanribeiro jeeanribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔️ 🚀

@jeeanribeiro jeeanribeiro merged commit 602d52d into stardust-develop Oct 26, 2022
@jeeanribeiro jeeanribeiro deleted the refactor/utils-submodules branch October 26, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Refactor more utils submodules
2 participants