Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move shared features to desktop #5049

Merged

Conversation

jeeanribeiro
Copy link
Contributor

Summary

This PR moves shared features folder to desktop and updates imports from it.
Extra: updates features imports for some mobile files by using its alias

Changelog

- Moves shared features to desktop
- Updates features imports

Relevant Issues

closes #5045

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro added type:chore House-keeping etc. stardust Related to the Stardust Protocol labels Oct 27, 2022
@jeeanribeiro jeeanribeiro linked an issue Oct 27, 2022 that may be closed by this pull request
4 tasks
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things, mainly depending on code inside of the desktop directory from shared, which we should try to avoid. Thanks for making this change man 🔥

packages/shared/components/SettingsMenu.svelte Outdated Show resolved Hide resolved
packages/shared/components/atoms/buttons/SendButton.svelte Outdated Show resolved Hide resolved
packages/desktop/electron/lib/menu.js Show resolved Hide resolved
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

Comment on lines +4 to +5
import { ReceiveAddressButton } from 'shared/components/atoms'
import { AccountActivity, SendButton } from '@components'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can these two imports be combined?

@maxwellmattryan maxwellmattryan merged commit 0ecfd4e into stardust-develop Nov 7, 2022
@maxwellmattryan maxwellmattryan deleted the chore/move-shared-features-to-desktop branch November 7, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:chore House-keeping etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Move shared features to desktop
2 participants