New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move shared features to desktop #5049
chore: move shared features to desktop #5049
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor things, mainly depending on code inside of the desktop directory from shared, which we should try to avoid. Thanks for making this change man 🔥
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
import { ReceiveAddressButton } from 'shared/components/atoms' | ||
import { AccountActivity, SendButton } from '@components' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these two imports be combined?
Summary
This PR moves shared features folder to desktop and updates imports from it.
Extra: updates features imports for some mobile files by using its alias
Changelog
Relevant Issues
closes #5045
Testing
Platforms
Checklist