Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove electron dep from mobile App.svelte #5088

Merged
merged 2 commits into from Nov 2, 2022

Conversation

begonaalvarezd
Copy link
Member

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Relevant Issues

Please list any related issues using development keywords.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@begonaalvarezd begonaalvarezd added type:chore House-keeping etc. platform:mobile stardust Related to the Stardust Protocol labels Nov 2, 2022
@begonaalvarezd begonaalvarezd self-assigned this Nov 2, 2022
Copy link
Contributor

@maxwellmattryan maxwellmattryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@maxwellmattryan maxwellmattryan changed the title chore: remove electron dep from mobile App.svelte chore: remove electron dep from mobile App.svelte Nov 2, 2022
@maxwellmattryan maxwellmattryan merged commit bc57f68 into stardust-develop Nov 2, 2022
@maxwellmattryan maxwellmattryan deleted the chore/lib-electron branch November 2, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:chore House-keeping etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants