Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/add NftPlaceholder component with rough outline #5090

Merged

Conversation

kraftjs
Copy link
Contributor

@kraftjs kraftjs commented Nov 2, 2022

Summary

Please summarize your changes, describing what they are and why they were made.

Media for NFTs will not be supported until completion of E12.M3. Until then, we will need a placeholder to show the NFT type. This placeholder will also be helpful after delivering E12.M3 while awaiting fetching of NFT data or if data is unavailable.

This placeholder will need to change depending on the NFT MimeType. It will also appear in the NFT details view, in the NFT gallery view, and in the send | receive | and activity flows of the wallet tab. I suggest an extra small, small, medium, large, extra large prop type to handle for this.

  • nft dropdown send options (extra small)
  • activity feed (small)
  • confirm send, receive, claim (medium)
  • gallery view and collection overview (large)
  • details view (extra large)

For now, just use a text placeholder. But a more long term solution is to create icons for each of the parent mime types.

Can expand in the future once we add media.

Changelog

- Created NftPlaceholderIcon component
- Created NftMediaContainer component

Relevant Issues

Please list any related issues using development keywords.

Closes #4910

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@kraftjs kraftjs added type:feature Adding a new feature or functionality stardust Related to the Stardust Protocol context:collectibles labels Nov 2, 2022
@kraftjs kraftjs added this to the E12.M1 - Generic NFT Support milestone Nov 2, 2022
@kraftjs kraftjs self-assigned this Nov 2, 2022
@kraftjs kraftjs linked an issue Nov 2, 2022 that may be closed by this pull request
10 tasks
kraftjs and others added 3 commits November 2, 2022 11:08
Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes

@kraftjs kraftjs marked this pull request as ready for review November 2, 2022 19:24
Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can update further as we develop the nft activities and the media pages

@nicole-obrien nicole-obrien merged commit 8ffa7c2 into stardust-develop Nov 2, 2022
@nicole-obrien nicole-obrien deleted the feat/create-nft-placeholder-component branch November 2, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:collectibles stardust Related to the Stardust Protocol type:feature Adding a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: E12.M1 - Create NftPlaceholder component
2 participants