New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/add NftPlaceholder component with rough outline #5090
Merged
nicole-obrien
merged 7 commits into
stardust-develop
from
feat/create-nft-placeholder-component
Nov 2, 2022
Merged
feat/add NftPlaceholder component with rough outline #5090
nicole-obrien
merged 7 commits into
stardust-develop
from
feat/create-nft-placeholder-component
Nov 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraftjs
added
type:feature
Adding a new feature or functionality
stardust
Related to the Stardust Protocol
context:collectibles
labels
Nov 2, 2022
10 tasks
… feat/create-nft-placeholder-component
…edia isn't ready to render
…properly Co-authored-by: Nicole O'Brien <nicole.obrien@iota.org>
nicole-obrien
suggested changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor changes
packages/shared/lib/core/collectibles/interfaces/nft.interface.ts
Outdated
Show resolved
Hide resolved
nicole-obrien
approved these changes
Nov 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can update further as we develop the nft activities and the media pages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
context:collectibles
stardust
Related to the Stardust Protocol
type:feature
Adding a new feature or functionality
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Media for NFTs will not be supported until completion of E12.M3. Until then, we will need a placeholder to show the NFT type. This placeholder will also be helpful after delivering E12.M3 while awaiting fetching of NFT data or if data is unavailable.
This placeholder will need to change depending on the NFT MimeType. It will also appear in the NFT details view, in the NFT gallery view, and in the send | receive | and activity flows of the wallet tab. I suggest an extra small, small, medium, large, extra large prop type to handle for this.
For now, just use a text placeholder. But a more long term solution is to create icons for each of the parent mime types.
Can expand in the future once we add media.
Changelog
Relevant Issues
Closes #4910
Testing
Platforms
Instructions
...
Checklist