Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-mobile: setup profile actions drawer #5097

Merged
merged 7 commits into from
Nov 3, 2022

Conversation

paul-boegelsack
Copy link
Contributor

Summary

This PR initializes the profile actions drawer.

Changelog

- Adds a drawer for the profile actions
- Adds a click event for profile actions button to open the drawer
- Updates the drawer to open from left to right if needed

Relevant Issues

Closes #4972

Testing

In order to test, you have to do the following steps:

  • in packages/desktop/index.js replace import App from './App.svelte' with import App from '../mobile/App.svelte'
  • in packages/shared/lib/core/profile/actions/active-profile/login.ts replace import { loginRouter } from '@core/router' with import { loginRouter } from '../../../../../../mobile/lib/core/router'.
  • in packages/mobile/features/features.ts enable the feature profileActions

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@paul-boegelsack paul-boegelsack added type:feature Adding a new feature or functionality platform:mobile context:wallet stardust Related to the Stardust Protocol labels Nov 3, 2022
@paul-boegelsack paul-boegelsack self-assigned this Nov 3, 2022
@paul-boegelsack paul-boegelsack linked an issue Nov 3, 2022 that may be closed by this pull request
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking and working amazing 🚀

@begonaalvarezd begonaalvarezd merged commit 40df780 into stardust-develop Nov 3, 2022
@begonaalvarezd begonaalvarezd deleted the feat-mobile/setup-profile-actions branch November 3, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:wallet stardust Related to the Stardust Protocol type:feature Adding a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Profile view: Toggle profile view
2 participants