refactor: platform lib file
#5144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxwellmattryan
added
type:refactor
maxwellmattryan
removed this from the E01.M6 - Separate platform and library code milestone
| import { IAppVersionDetails } from './app-version-details.interface' | ||
|
|
||
| export interface IPlatformEventMap { | ||
| 'menu-logout': void |
There was a problem hiding this comment.
just as a comment, these are very desktop events, we might want to improve this in the future
There was a problem hiding this comment.
Ah yes, this is true. Are some / any of these relevant for mobile?
There was a problem hiding this comment.
Not that I can see, but we will have to check when we have the bindings working, just something to consider for the future
begonaalvarezd
approved these changes
Nov 6, 2022
There was a problem hiding this comment.
lgtm and works smooth on mobile👌🏼 plus the mobile crash is gone 💪🏼
@MarkNerdi could you please review that everything also works as expected on desktop 🙏🏼 ?
…platform-lib-file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This code is old and should be touched up in accordance to our coding conventions.
Changelog
Relevant Issues
Closes #5095
Testing
Platforms
Instructions
Test general app functionality, specifically things involving platform operations like importing / exporting Stronghold files.
Checklist