Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove routing logic for core modules #5146

Merged
merged 19 commits into from Nov 11, 2022
Merged

refactor: remove routing logic for core modules #5146

merged 19 commits into from Nov 11, 2022

Conversation

maxwellmattryan
Copy link
Contributor

@maxwellmattryan maxwellmattryan commented Nov 4, 2022 •
edited

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Relevant Issues

Please list any related issues using development keywords.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

  • Test deleting an account

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@maxwellmattryan maxwellmattryan self-assigned this Nov 4, 2022
@maxwellmattryan maxwellmattryan added type:refactor Refactor code stardust Related to the Stardust Protocol labels Nov 4, 2022
@maxwellmattryan maxwellmattryan linked an issue Nov 4, 2022 that may be closed by this pull request
[Task]: Remove routing logic for core modules #5141
Closed
7 tasks
@maxwellmattryan maxwellmattryan marked this pull request as ready for review November 9, 2022 21:04
Tuditi
Tuditi reviewed Nov 11, 2022
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments, but otherwise I tested the app out and it works perfectly.

packages/shared/lib/core/router/enums/router-manager-extension-name.enum.ts Show resolved Hide resolved
packages/desktop/lib/routers/utils/getRouterForAppContext.ts Outdated Show resolved Hide resolved
packages/shared/components/modals/AccountActionsMenu.svelte Outdated Show resolved Hide resolved
packages/desktop/lib/routers/actions/resetRouterForAppContext.ts Show resolved Hide resolved
packages/shared/lib/core/router/actions/initialiseRouterManager.ts Outdated Show resolved Hide resolved
Tuditi
Tuditi approved these changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@Tuditi Tuditi merged commit d75daed into stardust-develop Nov 11, 2022
@Tuditi Tuditi deleted the refactor/remove-routing-logic-for-core-modules branch November 11, 2022 15:41
@begonaalvarezd begonaalvarezd mentioned this pull request Nov 17, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tuditi Tuditi Tuditi approved these changes

@nicole-obrien nicole-obrien Awaiting requested review from nicole-obrien

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@maxwellmattryan maxwellmattryan

Labels
stardust Related to the Stardust Protocol type:refactor Refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Remove routing logic for core modules
2 participants
@maxwellmattryan @Tuditi