Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: nft send form improvements #5157

Merged

Conversation

MarkNerdi996
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 commented Nov 7, 2022

Summary

This PR includes a few small improvements for the NFT SendForm and - Confirmation.

Changelog

- hide tabs if wallet owns no nfts
- fix title on send confirmation
- remove nft preview
- remove shimmer EVM from network selection

Relevant Issues

Closes #5153
Closes #5154
Closes #5052

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

Copy link
Contributor

@jeeanribeiro jeeanribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor fix and then I think it is good to go!

@MarkNerdi996 MarkNerdi996 merged commit 7733ecc into stardust-develop Nov 7, 2022
@MarkNerdi996 MarkNerdi996 deleted the enhancement/nft-send-form-improvements branch November 7, 2022 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:wallet stardust Related to the Stardust Protocol type:enhancement Enhancement to existing feature
Projects
None yet
2 participants