Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: add account colour to recipient input #5211

Conversation

nicole-obrien
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Add generic coloured circle component
- Use coloured circle in recipient selector
- Use coloured circle in account label

Relevant Issues

Please list any related issues using development keywords.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@nicole-obrien nicole-obrien added type:enhancement Enhancement to existing feature stardust Related to the Stardust Protocol labels Nov 14, 2022
@nicole-obrien nicole-obrien self-assigned this Nov 14, 2022
@nicole-obrien nicole-obrien changed the base branch from develop to stardust-develop November 14, 2022 21:46
@nicole-obrien nicole-obrien linked an issue Nov 14, 2022 that may be closed by this pull request
3 tasks
<Text type={TextType.pre} fontSize="sm" color="gray-600"
>{truncateString(option.value, 9, 9)}</Text
>
<div class="flex flex-row flex-1 justify-between">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the NFT icon i wrapped these items differently. I combined the slot with the first text, which makes more sense IMO.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the other way makes more sense, as the first slot will likely be fixed width and the next two elements will need to be flexible depending on the size of the content.

Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkNerdi996 MarkNerdi996 merged commit 4db5079 into stardust-develop Nov 15, 2022
@MarkNerdi996 MarkNerdi996 deleted the enhancement/add-account-colour-to-recipient-input branch November 15, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add wallet colour circle to recipient selector
2 participants