New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: add correct calculation for SDRUC on storage deposit breakdown #5224
Merged
nicole-obrien
merged 10 commits into
stardust-develop
from
feat/improve-balance-breakdown
Nov 16, 2022
Merged
enhancement: add correct calculation for SDRUC on storage deposit breakdown #5224
nicole-obrien
merged 10 commits into
stardust-develop
from
feat/improve-balance-breakdown
Nov 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add market value to balanceSummary
nicole-obrien
added
type:enhancement
Enhancement to existing feature
stardust
Related to the Stardust Protocol
labels
Nov 16, 2022
nicole-obrien
changed the title
Feat/improve balance breakdown
enhancement: improve balance breakdown
Nov 16, 2022
nicole-obrien
changed the title
enhancement: improve balance breakdown
enhancement: add correct calculation for SDRUC on storage deposit breakdown
Nov 16, 2022
nicole-obrien
changed the base branch from
stardust-develop
to
feat/output-consolidation
November 16, 2022 18:00
3 tasks
kraftjs
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! Code works and looks good. Just one small nit dealing with a Typescript warning.
packages/shared/components/popups/StorageDepositBreakdownPopup.svelte
Outdated
Show resolved
Hide resolved
….svelte Co-authored-by: Jason Kraft <jason.kraft@iota.org>
Base automatically changed from
feat/output-consolidation
to
stardust-develop
November 16, 2022 23:24
…ove-balance-breakdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
...
Changelog
Relevant Issues
...
Testing
Platforms
Instructions
...
Checklist