Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: add correct calculation for SDRUC on storage deposit breakdown #5224

Merged
merged 10 commits into from Nov 16, 2022

Conversation

nicole-obrien
Copy link
Contributor

@nicole-obrien nicole-obrien commented Nov 16, 2022

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Adds correct calculation for SDRUC storage deposits on the balance breakdown
- Adds fiat conversion

Relevant Issues

Please list any related issues using development keywords.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@nicole-obrien nicole-obrien added type:enhancement Enhancement to existing feature stardust Related to the Stardust Protocol labels Nov 16, 2022
@nicole-obrien nicole-obrien self-assigned this Nov 16, 2022
@nicole-obrien nicole-obrien changed the title Feat/improve balance breakdown enhancement: improve balance breakdown Nov 16, 2022
@nicole-obrien nicole-obrien changed the title enhancement: improve balance breakdown enhancement: add correct calculation for SDRUC on storage deposit breakdown Nov 16, 2022
@nicole-obrien nicole-obrien changed the base branch from stardust-develop to feat/output-consolidation November 16, 2022 18:00
@nicole-obrien nicole-obrien linked an issue Nov 16, 2022 that may be closed by this pull request
3 tasks
@nicole-obrien nicole-obrien marked this pull request as ready for review November 16, 2022 18:12
Copy link
Contributor

@kraftjs kraftjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Code works and looks good. Just one small nit dealing with a Typescript warning.

….svelte

Co-authored-by: Jason Kraft <jason.kraft@iota.org>
Base automatically changed from feat/output-consolidation to stardust-develop November 16, 2022 23:24
@nicole-obrien nicole-obrien merged commit 14417dd into stardust-develop Nov 16, 2022
@nicole-obrien nicole-obrien deleted the feat/improve-balance-breakdown branch November 16, 2022 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix pending transaction storage deposit calculation
2 participants