New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update wallet.rs dependency #5225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Introduces a new bug when sending an NFT that you have minted
c2a883e
to
0c42b17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unable to build the latest:
error /Users/nicoleobrien/repos/if/firefly-stardust/node_modules/@iota/wallet: Command failed.
Exit code: 101
Command: prebuild-install --runtime napi --tag-prefix nodejs-binding-v || npm run rebuild
Arguments:
Directory: /Users/nicoleobrien/repos/if/firefly-stardust/node_modules/@iota/wallet
Output:
prebuild-install warn install No prebuilt binaries found (target=6 runtime=napi arch=arm64 libc= platform=darwin)
> @iota/wallet@2.0.3-rc.6 rebuild
> node scripts/neon-build && tsc && node scripts/strip.js
> @iota/wallet@2.0.3-rc.6 build:neon
> cargo-cp-artifact -nc ./index.node -- cargo build --release --message-format=json-render-diagnostics
Updating git repository `https://github.com/iotaledger/wallet.rs`
Updating git repository `https://github.com/iotaledger/iota.rs`
Updating crates.io index
error: failed to select a version for `iota-wallet`.
... required by package `wallet v0.2.0 (/Users/nicoleobrien/repos/if/firefly-stardust/node_modules/@iota/wallet)`
versions that meet the requirements `*` are: 0.15.2
the package `wallet` depends on `iota-wallet`, with features: `events` but `iota-wallet` does not have these features.
for me it correctly uses the prebuilds when building |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Updated @iota/wallet package to latest
Changelog Wallet.rs:
Changelog
Relevant Issues
closes: #5219
...
Testing
Platforms
Instructions
...
Checklist