Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update wallet.rs dependency #5225

Merged
merged 10 commits into from Nov 30, 2022

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Nov 16, 2022

Summary

Updated @iota/wallet package to latest

Changelog Wallet.rs:

- Call `try_get_outputs_metadata` instead of `try_get_outputs` when possible (more efficient)
- Min storage deposit amount in `prepare_output()` with expiration unlock condition
- NFT id in `prepare_output()` when the NFT output still has the null id
- Don't require address approval on ledger nano during account recovery.
- Updated dependencies
- Add getIncomingTransactionData() and IncomingTransactionData type.
- Improve output consolidation logic.
- Improve syncing
- Added participation methods
- Fix for local time issue

Changelog

- Updated @iota/wallet package to 2.0.3-rc.8

Relevant Issues

closes: #5219
...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi added package:wallet.rs stardust Related to the Stardust Protocol labels Nov 16, 2022
@Tuditi Tuditi self-assigned this Nov 16, 2022
@Tuditi Tuditi linked an issue Nov 16, 2022 that may be closed by this pull request
4 tasks
Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Introduces a new bug when sending an NFT that you have minted

Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to build the latest:

error /Users/nicoleobrien/repos/if/firefly-stardust/node_modules/@iota/wallet: Command failed.
Exit code: 101
Command: prebuild-install --runtime napi --tag-prefix nodejs-binding-v || npm run rebuild
Arguments: 
Directory: /Users/nicoleobrien/repos/if/firefly-stardust/node_modules/@iota/wallet
Output:
prebuild-install warn install No prebuilt binaries found (target=6 runtime=napi arch=arm64 libc= platform=darwin)

> @iota/wallet@2.0.3-rc.6 rebuild
> node scripts/neon-build && tsc && node scripts/strip.js


> @iota/wallet@2.0.3-rc.6 build:neon
> cargo-cp-artifact -nc ./index.node -- cargo build --release --message-format=json-render-diagnostics

    Updating git repository `https://github.com/iotaledger/wallet.rs`
    Updating git repository `https://github.com/iotaledger/iota.rs`
    Updating crates.io index
error: failed to select a version for `iota-wallet`.
    ... required by package `wallet v0.2.0 (/Users/nicoleobrien/repos/if/firefly-stardust/node_modules/@iota/wallet)`
versions that meet the requirements `*` are: 0.15.2

the package `wallet` depends on `iota-wallet`, with features: `events` but `iota-wallet` does not have these features.

@MarkNerdi996
Copy link
Contributor

Unable to build the latest:

for me it correctly uses the prebuilds when building

Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicole-obrien nicole-obrien merged commit b76cb47 into stardust-develop Nov 30, 2022
@nicole-obrien nicole-obrien deleted the chore/update-wallet.rs branch November 30, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Update wallet.rs to new release
4 participants