Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: foundry tab #5233

Merged
merged 11 commits into from Nov 22, 2022
Merged

Conversation

MarkNerdi996
Copy link
Contributor

Summary

Add foundry information tab to ActivityDetails

Changelog

- Add foundry information tab to ActivityDetails

Relevant Issues

Closes #5189

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 added type:enhancement Enhancement to existing feature context:wallet stardust Related to the Stardust Protocol labels Nov 17, 2022
@MarkNerdi996 MarkNerdi996 self-assigned this Nov 17, 2022
@MarkNerdi996 MarkNerdi996 linked an issue Nov 17, 2022 that may be closed by this pull request
3 tasks
Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because you can mint a foundry without it following irc30. We should have three tabs:

  • Transaction
  • Foundry
    • Alias owner
    • Total supply
    • Circulating supply
    • Melted supply
  • Token Metadata
    • If follows IRC30 we parse as key values etc
    • else we just show a metadata block: ideally formatted

@MarkNerdi996
Copy link
Contributor Author

Currently we don't yet support non-IRC30 tokens. But I'm gonna implement the 3rd tab with the assumption for now that every token is IRC30.

Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicole-obrien nicole-obrien merged commit fc2bc50 into stardust-develop Nov 22, 2022
@nicole-obrien nicole-obrien deleted the enhancement/foundry-tab branch November 22, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:wallet stardust Related to the Stardust Protocol type:enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add tabs to minting / foundry activity
2 participants