Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update basic transaction structure #5235

Merged

Conversation

MarkNerdi996
Copy link
Contributor

Summary

Updates the code for BasicActivities to the new structure introduced by the tabbed info approach

Changelog

-  Remove keyvalues box duplication from `BasicActivityDetails`
- Rename `ActivityType.Transaction` to `ActivityType.Basic`
- Update `SendConfirmation` such that it correctly uses the new tabs for basic transactions

Relevant Issues

Closes #5234.

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 added type:chore House-keeping etc. context:wallet stardust Related to the Stardust Protocol labels Nov 17, 2022
@MarkNerdi996 MarkNerdi996 self-assigned this Nov 17, 2022
@MarkNerdi996 MarkNerdi996 linked an issue Nov 17, 2022 that may be closed by this pull request
3 tasks
Base automatically changed from enhancement/foundry-tab to stardust-develop November 22, 2022 09:48
@jeeanribeiro jeeanribeiro self-requested a review November 24, 2022 13:47
Copy link
Contributor

@jeeanribeiro jeeanribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and tested, LGTM!
I just needed to commit fixes to the handleDeepLink operations

@MarkNerdi996 MarkNerdi996 merged commit 2ac0841 into stardust-develop Nov 24, 2022
@MarkNerdi996 MarkNerdi996 deleted the refactor/update-basic-transaction-structure branch November 24, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:wallet stardust Related to the Stardust Protocol type:chore House-keeping etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Update basic transactions to new structure
2 participants