Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: nft metadata display #5237

Merged
merged 21 commits into from Nov 21, 2022
Merged

enhancement: nft metadata display #5237

merged 21 commits into from Nov 21, 2022

Conversation

jeeanribeiro
Copy link
Contributor

@jeeanribeiro jeeanribeiro commented Nov 17, 2022 •
edited

Summary

Enhances how NFT metadata is displayed by adding it in activity details tabs and in mint NFT confirmation popup

Relevant Issues

closes #5035

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro added type:ui stardust Related to the Stardust Protocol labels Nov 17, 2022
@jeeanribeiro jeeanribeiro self-assigned this Nov 17, 2022
@jeeanribeiro jeeanribeiro force-pushed the enhancement/nft-metadata-display branch from 4c1a21a to 1fd1763 Compare November 17, 2022 22:42
@jeeanribeiro jeeanribeiro linked an issue Nov 17, 2022 that may be closed by this pull request
[Task]: Add NFT metadata box on Activity Details #5035
Closed
3 tasks
@jeeanribeiro jeeanribeiro force-pushed the enhancement/nft-metadata-display branch from 9b134e6 to 5441dad Compare November 18, 2022 22:35
@jeeanribeiro jeeanribeiro marked this pull request as ready for review November 18, 2022 23:21
MarkNerdi996
MarkNerdi996 suggested changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments to address

packages/shared/components/molecules/NftActivityDetails.svelte Outdated Show resolved Hide resolved
packages/shared/components/molecules/activity-info/NftMetadataInformation.svelte Show resolved Hide resolved
packages/shared/lib/core/nfts/interfaces/nft.interface.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/nfts/utils/parseNftMetadata.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/nfts/utils/parseNftMetadata.ts Outdated Show resolved Hide resolved
@MarkNerdi996 MarkNerdi996 self-requested a review November 21, 2022 07:39
MarkNerdi996
MarkNerdi996 approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeeanribeiro jeeanribeiro merged commit aea0a19 into stardust-develop Nov 21, 2022
@jeeanribeiro jeeanribeiro deleted the enhancement/nft-metadata-display branch November 21, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkNerdi996 MarkNerdi996 MarkNerdi996 approved these changes

@nicole-obrien nicole-obrien Awaiting requested review from nicole-obrien

@kraftjs kraftjs Awaiting requested review from kraftjs

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@jeeanribeiro jeeanribeiro

Labels
stardust Related to the Stardust Protocol type:ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add NFT metadata box on Activity Details
2 participants
@jeeanribeiro @MarkNerdi996