feat-mobile: setup activity flow #5239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-boegelsack
added
platform:mobile
context:wallet
stardust
…le/setup-activity-details
begonaalvarezd
approved these changes
Nov 21, 2022
Comment on lines
+19
to
+23
| function handleOnClick(): void { | ||
| $selectedActivity = activity | ||
| $activityRouter?.goTo(ActivityRoute.Details) | ||
| onClick() | ||
| } |
There was a problem hiding this comment.
To make the component reusable in the future possibily with desktop, I wouldnt handle this logic here but let the view be the one to decide, so ideally we should add a onActivityClick to packages/mobile/components/ActivityList.svelte and handle the logic directlty in ActivityList, I think it might be better this way
| onClick() | ||
| } | ||
|
|
||
| function onReject(): void { |
There was a problem hiding this comment.
Same here, routing logic shouldnt be in a component but on the routing views
| $activityRouter?.goTo(ActivityRoute.Reject) | ||
| } | ||
|
|
||
| async function onClaim(): Promise<void> { |
There was a problem hiding this comment.
Same here, I would move all this out
…le/setup-activity-details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR initializes the activity flow for stardust mobile
Changelog
Relevant Issues
Testing
Enable
dashboard.activity.detailsanddashboard.activity.actionsinpackages/mobile/features/features.tsYou can use branch
dev-mode/mobile-stardustfor testing purposes.From the root of the repo in this PR's branch
refactor/mobile-routers-after-refactoryou can do:Platforms
Instructions
...
Checklist