Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add self transaction to activity directions #5243

Merged
merged 22 commits into from Nov 30, 2022

Conversation

MarkNerdi996
Copy link
Contributor

Summary

Add SelfTransaction as an ActivityDirection because everything gets more readable and explicit

Changelog

- Add `SelfTransaction` as an `ActivityDirection` 

Relevant Issues

Closes #4979

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 self-assigned this Nov 21, 2022
@MarkNerdi996 MarkNerdi996 linked an issue Nov 21, 2022 that may be closed by this pull request
@MarkNerdi996 MarkNerdi996 added type:refactor Refactor code context:wallet stardust Related to the Stardust Protocol labels Nov 21, 2022
Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes

Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicole-obrien nicole-obrien merged commit bbff32d into stardust-develop Nov 30, 2022
@nicole-obrien nicole-obrien deleted the refactor/self-transaction-as-direction branch November 30, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:wallet stardust Related to the Stardust Protocol type:refactor Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Extend ActivityDirection with SelfTransaction
2 participants