Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force refresh assets on first login #5252

Merged

Conversation

MarkNerdi996
Copy link
Contributor

Summary

Because of some wrong implementation on our side, the persisted token metadata is not complete, and therefore will never be updated, if not refreshed. This PR fixes this issue by forcing a refresh on all profiles while maintaining the verification state

Changelog

- Update `refreshAssetMetadata` to support maintaining the verification state after refreshing
- Add migration to add a force refresh
- restructure versioning of migrations

Relevant Issues

Closes #5251

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 added type:fix Fix for bug context:wallet stardust Related to the Stardust Protocol labels Nov 21, 2022
@MarkNerdi996 MarkNerdi996 self-assigned this Nov 21, 2022
@MarkNerdi996 MarkNerdi996 linked an issue Nov 21, 2022 that may be closed by this pull request
2 tasks
Base automatically changed from enhancement/foundry-tab to stardust-develop November 22, 2022 09:48
@nicole-obrien nicole-obrien merged commit ff30464 into stardust-develop Nov 22, 2022
@nicole-obrien nicole-obrien deleted the fix/force-refresh-assets-on-first-login branch November 22, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:wallet stardust Related to the Stardust Protocol type:fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add migration to force asset refresh for all profiles
2 participants