Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-mobile: fix drawer close reset current router delay #5278

Merged
merged 4 commits into from Nov 24, 2022

Conversation

begonaalvarezd
Copy link
Member

@begonaalvarezd begonaalvarezd commented Nov 23, 2022

Summary

Please summarize your changes, describing what they are and why they were made.

When the drawers closed, there was a jump if you were not in the initial route before we reset the active route right when the drawer is closing.

This PR aims to fix that by adding a delay to reset when the router is hidden.

Also the selected activity store has been moved to contexts

See the jump here:

Screencast.from.23-11-22.17.52.26.webm

Changelog

- [Please write a list of changes](feat-mobile: fix drawer close reset current router delay)

Relevant Issues

Please list any related issues using development keywords.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@begonaalvarezd begonaalvarezd added type:fix Fix for bug platform:mobile stardust Related to the Stardust Protocol labels Nov 23, 2022
@begonaalvarezd begonaalvarezd self-assigned this Nov 23, 2022
Copy link
Contributor

@paul-boegelsack paul-boegelsack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better now than in the screencast 🔥

@begonaalvarezd begonaalvarezd merged commit c62cdc2 into stardust-develop Nov 24, 2022
@begonaalvarezd begonaalvarezd deleted the feat-mobile/fix-drawer-close branch November 24, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants