Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat-mobile: add review screen to send flow #5284

Merged
merged 5 commits into from Nov 25, 2022

Conversation

begonaalvarezd
Copy link
Member

@begonaalvarezd begonaalvarezd commented Nov 24, 2022

Summary

Please summarize your changes, describing what they are and why they were made.

This PR:

  • adds the review screen to the send flow
  • refactors the send routing logic to be more centralized

Please note the intention of this PR is not being super strict with figma designs 馃檹馃徏

Changelog

- feat-mobile: add review screen to send flow

Relevant Issues

Please list any related issues using development keywords.

Close #4949

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@begonaalvarezd begonaalvarezd added type:feature Adding a new feature or functionality platform:mobile stardust Related to the Stardust Protocol labels Nov 24, 2022
@begonaalvarezd begonaalvarezd self-assigned this Nov 24, 2022
@begonaalvarezd begonaalvarezd linked an issue Nov 24, 2022 that may be closed by this pull request
Copy link
Contributor

@paul-boegelsack paul-boegelsack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another great piece for sending 馃挴馃殌

@paul-boegelsack paul-boegelsack merged commit 6fde81a into stardust-develop Nov 25, 2022
@paul-boegelsack paul-boegelsack deleted the feat-mobile/send-confirm branch November 25, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:feature Adding a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Send Flow: Review
2 participants