Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: parsed smart contract metadata UI #5295

Merged
merged 23 commits into from Nov 30, 2022
Merged

feat: parsed smart contract metadata UI #5295

merged 23 commits into from Nov 30, 2022

Conversation

jeeanribeiro
Copy link
Contributor

Summary

Adds "Smart Contract" tab in ActivityInformation with parsed smart contract metadata

Changelog

- Adds getDestinationNetworkFromAddress util
- Adds parseLayer2Metadata util
- Adds smart contract related strings
- Adds destinationNetwork in BaseActivityType and generateActivity function
- Adds SmartContractActivityInformation component
- Add Smart Contract tab in ActivityInformation

Relevant Issues

closes #5242

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro added type:feature Adding a new feature or functionality context:wallet stardust Related to the Stardust Protocol labels Nov 27, 2022
@jeeanribeiro jeeanribeiro self-assigned this Nov 27, 2022
@jeeanribeiro jeeanribeiro linked an issue Nov 27, 2022 that may be closed by this pull request
[Task]: Show parsed metadata in the UI #5242
Closed
5 tasks
MarkNerdi996
MarkNerdi996 previously requested changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT, 2 small comments to address

packages/shared/components/molecules/activity-info/SmartContractActivityInformation.svelte Outdated Show resolved Hide resolved
packages/shared/components/molecules/activity-info/SmartContractActivityInformation.svelte Outdated Show resolved Hide resolved
Tuditi
Tuditi reviewed Nov 28, 2022
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments. I'm missing the smart contract metadata from the send confirmation pop-up. Ideally, it looks the same as the activity popup.

packages/shared/components/molecules/activity-info/SmartContractActivityInformation.svelte Outdated Show resolved Hide resolved
packages/shared/lib/core/layer-2/utils/parseLayer2Metadata.ts Show resolved Hide resolved
packages/shared/lib/core/layer-2/utils/parseLayer2Metadata.ts Outdated Show resolved Hide resolved
packages/shared/lib/core/layer-2/utils/parseLayer2Metadata.ts Outdated Show resolved Hide resolved
@jeeanribeiro jeeanribeiro force-pushed the feat/parsed-metadata-ui branch 2 times, most recently from 9a9d0a8 to 2717dc4 Compare November 28, 2022 19:25
Tuditi
Tuditi suggested changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I found one minor issue however:

The gift storage deposit is appearing
on the smart contract tabs when sending a native token to L2.

image

packages/shared/components/molecules/activity-info/SmartContractActivityInformation.svelte Outdated Show resolved Hide resolved
packages/shared/lib/core/wallet/utils/generateActivity/generateTransactionActivity.ts Outdated Show resolved Hide resolved
Tuditi
Tuditi approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥

@Tuditi Tuditi dismissed MarkNerdi996’s stale review November 30, 2022 18:38

Jean addressed your comments

@Tuditi Tuditi merged commit 352aa41 into stardust-develop Nov 30, 2022
@Tuditi Tuditi deleted the feat/parsed-metadata-ui branch November 30, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvarley100 cvarley100 Awaiting requested review from cvarley100

@MarkNerdi996 MarkNerdi996 Awaiting requested review from MarkNerdi996

@Tuditi Tuditi Awaiting requested review from Tuditi

Assignees

@jeeanribeiro jeeanribeiro

Labels
context:wallet stardust Related to the Stardust Protocol type:feature Adding a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Show parsed metadata in the UI
3 participants
@jeeanribeiro @Tuditi @MarkNerdi996