Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: improve gallery view UI #5296

Merged
merged 5 commits into from Nov 29, 2022

Conversation

MarkNerdi996
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 commented Nov 28, 2022

Summary

This PR updates the current implementation of the GalleryView to the figma designs.

Changelog

- add NFT amount to title
- fix font size and weights of title + nft names
- fix border + bg color of nft items
- fix some margins

Relevant Issues

Closes #3442

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 added context:wallet type:ui stardust Related to the Stardust Protocol labels Nov 28, 2022
@MarkNerdi996 MarkNerdi996 self-assigned this Nov 28, 2022
@MarkNerdi996 MarkNerdi996 linked an issue Nov 28, 2022 that may be closed by this pull request
6 tasks
Copy link
Contributor

@jeeanribeiro jeeanribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Light mode looks good to me
image

In dark mode I can't see the NFT title
image

Copy link
Contributor

@jeeanribeiro jeeanribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeeanribeiro jeeanribeiro merged commit 16cf28a into stardust-develop Nov 29, 2022
@jeeanribeiro jeeanribeiro deleted the enhancement/improve-gallery-view-ui branch November 29, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:wallet stardust Related to the Stardust Protocol type:ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask]: E12.M2 - UI: non empty collectibles gallery
2 participants