feat: add searchbar to collectible tabs #5298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkNerdi996
added
type:feature
5 tasks
kraftjs
reviewed
Nov 28, 2022
| nftList = nftList.filter((nft) => nft.name.toLowerCase().includes($nftSearchTerm.toLowerCase())) | ||
| } | ||
|
|
||
| return nftList.sort((nft1, nft2) => (nft2.name < nft1.name ? 1 : -1)) |
There was a problem hiding this comment.
This doesn't sort alphabetically; it's sorted by unicode value. "NFT" is placed before "application". It's not an issue but we should figure out how we want to default sort the NFTs.
There was a problem hiding this comment.
ah thats true, i'll change this to nft2.name.toLowercase() < nft1.name.toLowercase()
| <div class="flex flex-row justify-between"> | ||
| <div class="flex flex-row text-left space-x-1 items-center"> | ||
| <Text fontSize="text-14" fontWeight={FontWeight.semibold}>{localize('views.collectibles.gallery.title')}</Text> | ||
| <Text fontSize="text-14" fontWeight={FontWeight.semibold} color="gray-500">• {$selectedAccountNfts.length}</Text |
There was a problem hiding this comment.
Do we want to show $selectedAccountNfts.length or do we want to show the number of returned NFTs from the search, so $queriedNfts.length?
Base automatically changed from
enhancement/improve-gallery-view-ui
to
stardust-develop
November 29, 2022 13:55
…nft-search-in-gallery
kraftjs
approved these changes
Nov 29, 2022
kraftjs
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a togglable Searchbar on the Collectible Tabs, to search the NFTs by their name
Changelog
Relevant Issues
Closes #3444
Testing
Platforms
Instructions
...
Checklist