Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update nft placeholder icons #5302

Merged
merged 18 commits into from Dec 8, 2022

Conversation

kraftjs
Copy link
Contributor

@kraftjs kraftjs commented Nov 29, 2022

Summary

Please summarize your changes, describing what they are and why they were made.

Update placeholder icons to newly provided ones by design.

Changelog

- Create svg placeholder file for each parent MIME type and an unknown placeholder
- Add created svgs to enums and rest of file structure
- Adjust NftPlaceholder icon shown depending on NftMediaContainer size
- Adjust detailsView and galleryView styling to suit nftPlaceholderIcons

Relevant Issues

Please list any related issues using development keywords.

Closes #5172

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@kraftjs kraftjs added type:ui stardust Related to the Stardust Protocol labels Nov 29, 2022
@kraftjs kraftjs added this to the E12.M1 - Generic NFT Support milestone Nov 29, 2022
@kraftjs kraftjs self-assigned this Nov 29, 2022
@kraftjs kraftjs linked an issue Nov 29, 2022 that may be closed by this pull request
3 tasks
@kraftjs kraftjs marked this pull request as ready for review December 7, 2022 01:11
@nicole-obrien nicole-obrien merged commit 3335c7e into stardust-develop Dec 8, 2022
@nicole-obrien nicole-obrien deleted the ui/update-nft-placeholder-icons branch December 8, 2022 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Update the NFT placeholder icons
2 participants