Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: update shared nft details for mobile usage #5309

Conversation

paul-boegelsack
Copy link
Contributor

Summary

This PR aims to make the nft details component of shared reusable for mobile.

Changelog

- Updates styling of the nft details

Relevant Issues

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro changed the title ui: update shared ntf details for mobile usage ui: update shared nft details for mobile usage Nov 30, 2022
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@begonaalvarezd begonaalvarezd merged commit 561744d into stardust-develop Dec 1, 2022
@begonaalvarezd begonaalvarezd deleted the enhancement/update-shared-nft-details-for-mobile-usage branch December 1, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:wallet stardust Related to the Stardust Protocol type:ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants