Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: network input validation #5312

Merged
merged 2 commits into from Dec 1, 2022
Merged

fix: network input validation #5312

merged 2 commits into from Dec 1, 2022

Conversation

jeeanribeiro
Copy link
Contributor

Summary

Adds condition to only validate network input address if it is not layer1 address

Relevant Issues

closes #5311

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro added type:fix Fix for bug stardust Related to the Stardust Protocol labels Nov 30, 2022
@jeeanribeiro jeeanribeiro self-assigned this Nov 30, 2022
@jeeanribeiro jeeanribeiro linked an issue Nov 30, 2022 that may be closed by this pull request
[Task]: Remove network input validation when there is Shimmer address #5311
Closed
5 tasks
MarkNerdi996
MarkNerdi996 approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkNerdi996 MarkNerdi996 merged commit 39030ab into stardust-develop Dec 1, 2022
@MarkNerdi996 MarkNerdi996 deleted the fix/network-input-validation branch December 1, 2022 08:40
@MarkNerdi996 MarkNerdi996 mentioned this pull request Dec 1, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkNerdi996 MarkNerdi996 MarkNerdi996 approved these changes

@Tuditi Tuditi Awaiting requested review from Tuditi

@cvarley100 cvarley100 Awaiting requested review from cvarley100

Assignees

@jeeanribeiro jeeanribeiro

Labels
stardust Related to the Stardust Protocol type:fix Fix for bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Remove network input validation when there is Shimmer address
2 participants
@jeeanribeiro @MarkNerdi996