Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send nft button #5329

Merged
merged 4 commits into from Dec 2, 2022
Merged

feat: send nft button #5329

merged 4 commits into from Dec 2, 2022

Conversation

MarkNerdi996
Copy link
Contributor

Summary

This PR adds functionality to the send button in the Nft DetailsView. After a successful sending, the user gets redirected to the Wallet view

Changelog

- `Send` button on Nft Details opens prefilled `SendForm`
- Successful sending redirects user to `Wallet` view

Relevant Issues

Closes #5315

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 added type:enhancement Enhancement to existing feature context:wallet stardust Related to the Stardust Protocol labels Dec 2, 2022
@MarkNerdi996 MarkNerdi996 self-assigned this Dec 2, 2022
@MarkNerdi996 MarkNerdi996 linked an issue Dec 2, 2022 that may be closed by this pull request
3 tasks
Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't reset the collectibles router, so navigating back to the collectibles tab shows the same nft page

Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you have merged develop in, it works as expected!

@nicole-obrien nicole-obrien merged commit 9c8a7a4 into stardust-develop Dec 2, 2022
@nicole-obrien nicole-obrien deleted the feat/send-nft-button branch December 2, 2022 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:wallet stardust Related to the Stardust Protocol type:enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Open send form from collectible details view
2 participants