Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: combine asset input and asset slider input #5331

Conversation

MarkNerdi996
Copy link
Contributor

@MarkNerdi996 MarkNerdi996 commented Dec 2, 2022

Summary

This PR combines the AssetAmountInput from the SendForm with the AssetAmountSliderInput from the BurnNativeTokensPopup

Changelog

- combine asset input and asset slider input

Relevant Issues

Closes #5318

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 added type:refactor Refactor code context:wallet stardust Related to the Stardust Protocol labels Dec 2, 2022
@MarkNerdi996 MarkNerdi996 self-assigned this Dec 2, 2022
@MarkNerdi996 MarkNerdi996 linked an issue Dec 2, 2022 that may be closed by this pull request
3 tasks
@MarkNerdi996 MarkNerdi996 linked an issue Dec 5, 2022 that may be closed by this pull request
3 tasks
@MarkNerdi996 MarkNerdi996 deleted the refactor/combine-asset-input-and-asset-slider-input branch December 5, 2022 13:55
@MarkNerdi996 MarkNerdi996 restored the refactor/combine-asset-input-and-asset-slider-input branch December 5, 2022 13:58
@MarkNerdi996 MarkNerdi996 reopened this Dec 5, 2022
Copy link
Contributor

@jeeanribeiro jeeanribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeeanribeiro jeeanribeiro merged commit 83999bf into stardust-develop Dec 5, 2022
@jeeanribeiro jeeanribeiro deleted the refactor/combine-asset-input-and-asset-slider-input branch December 5, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:wallet stardust Related to the Stardust Protocol type:refactor Refactor code
Projects
None yet
2 participants