Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add expiration to mobile send flow #5336

Merged
merged 3 commits into from Dec 8, 2022

Conversation

begonaalvarezd
Copy link
Member

Summary

Please summarize your changes, describing what they are and why they were made.

Add expiration time selector to mobile send flow

Changelog

feat: add expiration to mobile send flow

Relevant Issues

Please list any related issues using development keywords.

Close #4950

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@begonaalvarezd begonaalvarezd added type:feature Adding a new feature or functionality platform:mobile stardust Related to the Stardust Protocol labels Dec 2, 2022
@begonaalvarezd begonaalvarezd self-assigned this Dec 2, 2022
@begonaalvarezd begonaalvarezd linked an issue Dec 2, 2022 that may be closed by this pull request
Copy link
Contributor

@paul-boegelsack paul-boegelsack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! 🔥 I just get an error when I open the drawer:

index.js:31 TypeError: Cannot convert undefined to a BigInt at BigInt (<anonymous>) at getOutputOptions (getOutputOptions.ts:25:1) at SendRouter.svelte:70:1 at Generator.next (<anonymous>) at SendRouter.svelte:7:1 at new Promise (<anonymous>) at __awaiter (SendRouter.svelte:3:1) at prepareTransactionOutput (SendRouter.svelte:68:1) at refreshSendConfirmationState (SendRouter.svelte:98:1) at $$self.$$.update (SendRouter.svelte:36:1)

I don't get the error with stardust-develop so I guess this is something new? I also saw your todo comment at this line but I'm not sure if it also refers to the error somehow?

Copy link
Contributor

@paul-boegelsack paul-boegelsack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still get the error with a fresh clone and a fresh installation of the dependencies. I'm not sure, maybe there is something wrong on my side. Anyhow, the error doesn't really break the flow at the moment so I approve 👍

@paul-boegelsack paul-boegelsack merged commit 9cba1e8 into stardust-develop Dec 8, 2022
@paul-boegelsack paul-boegelsack deleted the feat-mobile/expiration-date branch December 8, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:feature Adding a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Send Flow: Expiration time
2 participants