New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds voting power management #5337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The flows don't work if you have a locale in another language (due to the different comma). I think it's a problem with the AssetAmountInput. So I'll open a separate issue for that
<TextHint info text={localize('popups.manageVotingPower.hint')} /> | ||
</div> | ||
<div class="flex flex-row flex-nowrap w-full space-x-4"> | ||
<Button outline classes="w-full" disabled={$selectedAccount.isTransferring} onClick={handleBack}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a minor suggestion, it is slightly better for performance + readability, to extract the property of the $selectedAccount.isTransferring
variable to a separate reactive variable (i.e.: isTransferring
). Then whenever something changes on the selectedAccount
object, the reactive code is only run once
packages/shared/components/popups/ManageVotingPowerPopup.svelte
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary
Adds voting power management UI and functionality
Changelog
Relevant Issues
closes #5262
Testing
Platforms
Checklist