Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add nft after claiming #5342

Merged
merged 3 commits into from Dec 5, 2022

Conversation

MarkNerdi996
Copy link
Contributor

Summary

This PR fixes the issue that NFTs are not added to the NFT list after they are claimed by the user

Changelog

- add NFTs to the NFT list after they are claimed by the user

Relevant Issues

Closes #5320

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

MarkNerdi996 and others added 2 commits December 2, 2022 16:39
Co-authored-by: MarkNerdi <MarkNerdi@users.noreply.github.com>
@MarkNerdi996 MarkNerdi996 added type:enhancement Enhancement to existing feature context:wallet stardust Related to the Stardust Protocol labels Dec 5, 2022
@MarkNerdi996 MarkNerdi996 self-assigned this Dec 5, 2022
@MarkNerdi996 MarkNerdi996 linked an issue Dec 5, 2022 that may be closed by this pull request
1 task
@nicole-obrien nicole-obrien added type:fix Fix for bug and removed type:enhancement Enhancement to existing feature labels Dec 5, 2022
Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicole-obrien nicole-obrien merged commit dddb8ab into stardust-develop Dec 5, 2022
@nicole-obrien nicole-obrien deleted the fix/add-nft-after-claiming branch December 5, 2022 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:wallet stardust Related to the Stardust Protocol type:fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add NFT to store if claimed
2 participants