Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: selector input unwanted readonly #5354

Merged
merged 3 commits into from Dec 6, 2022

Conversation

jeeanribeiro
Copy link
Contributor

Summary

readonly prop should have an initial value of null or undefined, because svelte is adding the attribute in the HTML, and the HTML does not understand the readonly attribute with false or true value, just understand the absence of readonly prop

Changelog

- Sets the initial value of readonly prop in SelectorInput to null

Testing

Platforms

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@jeeanribeiro jeeanribeiro added type:fix Fix for bug stardust Related to the Stardust Protocol labels Dec 5, 2022
@jeeanribeiro jeeanribeiro self-assigned this Dec 5, 2022
@Tuditi Tuditi force-pushed the fix/selector-input-unwanted-readonly branch from 6f7a6b4 to be63792 Compare December 6, 2022 08:41
Copy link
Contributor

@Tuditi Tuditi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a commit to fix it also on NftInput and AssetAmountInput

Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tuditi Tuditi merged commit b3aca81 into stardust-develop Dec 6, 2022
@Tuditi Tuditi deleted the fix/selector-input-unwanted-readonly branch December 6, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants