Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open nft media in browser #5359

Merged
merged 11 commits into from Dec 7, 2022

Conversation

MarkNerdi996
Copy link
Contributor

Summary

Implement View media in browser on nft details

Changelog

- Implement `View media in browser` on nft details

Relevant Issues

Closes #3455

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 added type:feature Adding a new feature or functionality context:wallet stardust Related to the Stardust Protocol labels Dec 6, 2022
@MarkNerdi996 MarkNerdi996 self-assigned this Dec 6, 2022
@MarkNerdi996 MarkNerdi996 linked an issue Dec 6, 2022 that may be closed by this pull request
4 tasks
Base automatically changed from enhancement/update-url-whitelist to stardust-develop December 7, 2022 16:42
Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicole-obrien nicole-obrien merged commit 4163211 into stardust-develop Dec 7, 2022
@nicole-obrien nicole-obrien deleted the feat/open-nft-media-in-browser branch December 7, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:wallet stardust Related to the Stardust Protocol type:feature Adding a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: E12.M2 - Peripheral action - view nft in IPFS
2 participants