Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: nft name on activity tile #5366

Merged
merged 5 commits into from Dec 7, 2022

Conversation

nicole-obrien
Copy link
Contributor

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Relevant Issues

Please list any related issues using development keywords.

...

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@nicole-obrien nicole-obrien added type:enhancement Enhancement to existing feature stardust Related to the Stardust Protocol labels Dec 7, 2022
@nicole-obrien nicole-obrien self-assigned this Dec 7, 2022
@nicole-obrien nicole-obrien linked an issue Dec 7, 2022 that may be closed by this pull request
3 tasks
@nicole-obrien nicole-obrien marked this pull request as ready for review December 7, 2022 11:01
Comment on lines 62 to 69
<Text
fontWeight={FontWeight.semibold}
lineHeight="140"
color={isIncoming ? 'blue-700' : ''}
classes="whitespace-nowrap"
>
{nft?.name ?? ''}
</Text>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs some max width and truncate for long NFT names

Copy link
Contributor

@MarkNerdi996 MarkNerdi996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@nicole-obrien nicole-obrien merged commit 126f354 into stardust-develop Dec 7, 2022
@nicole-obrien nicole-obrien deleted the enhancement/add-nft-name-to-tile branch December 7, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stardust Related to the Stardust Protocol type:enhancement Enhancement to existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add name of NFT to activity tile
3 participants