Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: callback error #5369

Merged
merged 2 commits into from Dec 7, 2022
Merged

fix: callback error #5369

merged 2 commits into from Dec 7, 2022

Conversation

Tuditi
Copy link
Contributor

@Tuditi Tuditi commented Dec 7, 2022

Summary

Fixes an error that is thrown by the event callback in case the activity is not found

...

Changelog

- add optional chaining to activity

Relevant Issues

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Send an internal transaction with 1 glow and then accept it from your other wallet. No error should be seen in the console.

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@Tuditi Tuditi added the type:fix Fix for bug label Dec 7, 2022
@Tuditi Tuditi self-assigned this Dec 7, 2022
@nicole-obrien nicole-obrien merged commit 91af233 into stardust-develop Dec 7, 2022
@nicole-obrien nicole-obrien deleted the fix/callback-error branch December 7, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants