Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix corrupted profiles #5387

Merged
merged 6 commits into from Dec 13, 2022
Merged

Conversation

MarkNerdi996
Copy link
Contributor

Summary

This PR includes the fix such that profiles dont get corrupted anymore + a migration to fix already broken profiles

Changelog

- increase app version to 7
- migration to fix already broken profiles
- profiles dont get corrupted anymore

Relevant Issues

Closes #5386

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows
  • Mobile
    • iOS
    • Android

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick all of the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@MarkNerdi996 MarkNerdi996 added type:fix Fix for bug context:wallet stardust Related to the Stardust Protocol labels Dec 9, 2022
@MarkNerdi996 MarkNerdi996 self-assigned this Dec 9, 2022
@MarkNerdi996 MarkNerdi996 linked an issue Dec 9, 2022 that may be closed by this pull request
Copy link
Contributor

@nicole-obrien nicole-obrien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicole-obrien nicole-obrien merged commit 32c5718 into stardust-develop Dec 13, 2022
@nicole-obrien nicole-obrien deleted the fix/fix-corrupted-profiles branch December 13, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
context:wallet stardust Related to the Stardust Protocol type:fix Fix for bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix corrupted profiles
2 participants